This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[firebase_admob] update AGP, gradle and admob #1942
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Aug 6, 2019
packages/firebase_admob/CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## 0.9.0+4 | |||
|
|||
* Android : Update AGP, gradle and admob. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include the warning removal here in the changelog?
collinjackson
added
the
submit queue
The Flutter team is in the process of landing this PR.
label
Aug 6, 2019
collinjackson
approved these changes
Aug 8, 2019
Co-Authored-By: Collin Jackson <[email protected]>
Co-Authored-By: Collin Jackson <[email protected]>
@collinjackson Let's get this merged? |
Migrated to firebase/flutterfire#34 |
collinjackson
added a commit
to collinjackson/flutterfire
that referenced
this pull request
Aug 30, 2019
collinjackson
added a commit
to firebase/flutterfire
that referenced
this pull request
Aug 30, 2019
* [firebase_admob] update AGP, gradle and admob * Update CHANGELOG entry with description of #2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Warning example:
variable.equals(constant)
=>constant.equals(variable)
to avoid null pointer exceptionint a = call.argument(constant)
=>Integer a= call.argument(constant)
to remove possible null pointer warning.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?