FC-1437: add tests for order-by with limit and offset #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cap10morgan
approved these changes
Oct 13, 2022
| (comp (drop offset) | ||
| (take limit)) | ||
| all-results)) | ||
| "returns subjects only up to the limit after the offset")))))))) |
There was a problem hiding this comment.
I'd have slightly more confidence in these tests if the expected values were either hard-coded values or calculated/compared in a much more primitive way (vs. the logic implementation in the code under test).
E.g. for offest=1, limit=1
(is (= 1 (count subject)))
(is (= (first subject) (second all-results)))Otherwise they could be wrong for the same reason(s) and agree with each other and pass.
Not a huge deal here, so I'll leave it up to you.
There was a problem hiding this comment.
yeah, i definitely had some hesitance about using exactly the same algorithm too. i think i got too clever in the name of test robustness. i'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the code added in fluree/db#207