Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make error-formatting work from servers #604

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

mpoffald
Copy link
Contributor

Part of #312

Small fix to make sure error messages report valid top-level query keys when the error-formatting fn is used in coercion by h-a-g/server.

When querying via h-a-g/server, the query request schema wraps the fql schema in a dispatch (fql vs sparql). So we can't just assume that the first keyword is the actual top-level key of the query.

When querying via h-a-g/server, the query request schema wraps the fql schema in a dispatch (fql vs sparql). So we can't assume that the first keyword is the actual top-level key of the query.
@mpoffald mpoffald requested a review from a team October 25, 2023 18:32
Copy link
Contributor

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👔

@mpoffald mpoffald merged commit 6320e16 into main Oct 26, 2023
5 checks passed
@mpoffald mpoffald deleted the feature/fix-errors-for-servers branch October 26, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants