Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aliases to build commands #1

Closed
wants to merge 1 commit into from
Closed

Conversation

jobez
Copy link

@jobez jobez commented Oct 21, 2020

Hello! I am excited to explore this project.

Following the readme to build locally, when I tried entering

make install

I was met with

make install
clojure -M:jar
Execution error (FileNotFoundException) at clojure.main/main (main.java:40).
Could not locate hf/depstar/jar__init.class, hf/depstar/jar.clj or hf/depstar/jar.cljc on classpath.

To which adding the aliases for the extra deps resolves (in the case of having clojure-1.10.1.645 installed)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cap10morgan
Copy link
Contributor

@jobez Thank you for your contribution!

Currently the minimum required version of clojure tools-deps is 1.10.1.697. Is it difficult to upgrade to that version (or later) for you? At the very least we should document this requirement more explicitly.

@hanswand hanswand closed this Oct 21, 2020
@hanswand hanswand reopened this Oct 21, 2020
@jobez
Copy link
Author

jobez commented Oct 21, 2020

Documenting it would be lovely! Updating is a bit more involved for me unfortunately, but no worries I can keep my changes stashed away while I tinker about ⛵

dpetran added a commit that referenced this pull request May 17, 2024
Three approaches considered:

1) just document that :values needs to appear first
2) discard solutions that don't match the given solution
3) during the parse step, sort the patterns so :values is first

I don't like #1, though that's the most expedient. #2 is a bit wasteful as it forces us
to generate useless solutions. #3 is doable, and may be a minimal requirement in basic
query planning.

This implements solution #2.
dpetran added a commit that referenced this pull request May 31, 2024
Three approaches considered:

1) just document that :values needs to appear first
2) discard solutions that don't match the given solution
3) during the parse step, sort the patterns so :values is first

I don't like #1, though that's the most expedient. #2 is a bit wasteful as it forces us
to generate useless solutions. #3 is doable, and may be a minimal requirement in basic
query planning.

This implements solution #2.
dpetran added a commit that referenced this pull request Jun 12, 2024
Three approaches considered:

1) just document that :values needs to appear first
2) discard solutions that don't match the given solution
3) during the parse step, sort the patterns so :values is first

I don't like #1, though that's the most expedient. #2 is a bit wasteful as it forces us
to generate useless solutions. #3 is doable, and may be a minimal requirement in basic
query planning.

This implements solution #2.
JaceRockman pushed a commit that referenced this pull request Jul 2, 2024
Three approaches considered:

1) just document that :values needs to appear first
2) discard solutions that don't match the given solution
3) during the parse step, sort the patterns so :values is first

I don't like #1, though that's the most expedient. #2 is a bit wasteful as it forces us
to generate useless solutions. #3 is doable, and may be a minimal requirement in basic
query planning.

This implements solution #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants