Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile: install ruby gems with parallel #674

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

Watson1978
Copy link
Contributor

Seems It appears to be taking a long time to install ruby gems on windows environment. So this patch will introduce parallel install to reduce installation time.

@daipom
Copy link
Contributor

daipom commented Aug 21, 2024

Thanks! Great job!

@daipom
Copy link
Contributor

daipom commented Aug 21, 2024

#675 will solve the failing CI.
After it is merged, let's rebase this.

fluent-package/Rakefile Outdated Show resolved Hide resolved
Seems It appears to be taking a long time to install ruby gems on windows environment.
So this patch will introduce parallel install to reduce installation time.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 75605d8 into fluent:master Aug 22, 2024
54 checks passed
@kenhys
Copy link
Contributor

kenhys commented Aug 22, 2024

Thanks!

@Watson1978 Watson1978 deleted the bundler branch August 22, 2024 03:14
daipom pushed a commit that referenced this pull request Nov 8, 2024
Seems It appears to be taking a long time to install ruby gems on
windows environment. So this patch will introduce parallel install to
reduce installation time.


See #674

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Co-authored-by: Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants