add fluentbit daemonset hostPath toggle #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Engel <[email protected]>
wenchajun
reviewed
Sep 17, 2023
| }, | ||
| } | ||
|
|
||
| if !fb.Spec.DisableLogVolumes { |
There was a problem hiding this comment.
Should the field be considered empty as well?
There was a problem hiding this comment.
Not necessarily. Since it's a non-pointer bool, the default false will be used if it is unset.
benjaminhuo
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currenly, fluentbit daemonset mounts three hostPath volumes. HostPath is forbidden in some k8s environments. This PR adds a flag
disableLogVolumesto disable these mounts.Which issue(s) this PR fixes:
Fixes #907
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: