Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImagePullSecret for fluentd #891

Merged
merged 1 commit into from
Aug 28, 2023
+9 −1
Merged

Add ImagePullSecret for fluentd #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/fluent-operator/templates/fluentd-fluentd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ spec:
port: {{ .Values.fluentd.port }}
replicas: {{ .Values.fluentd.replicas }}
image: {{ .Values.fluentd.image.repository }}:{{ .Values.fluentd.image.tag }}
{{- if .Values.fluentd.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.fluentd.imagePullSecrets | indent 4 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  {{- if .Values.fluentd.imagePullSecrets }}
  imagePullSecrets:
  {{ toYaml .Values.fluentd.imagePullSecrets | indent 4 }}
{{end}}

There seems to be an end missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenchajun Added, Thanks

{{- end }}
mode: {{ .Values.fluentd.mode }}
resources:
{{- toYaml .Values.fluentd.resources | nindent 4 }}
Expand Down
6 changes: 5 additions & 1 deletion charts/fluent-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ fluentbit:
# - name: "image-pull-secret"
secrets: []
# fluent-bit daemonset use host network
hostNetwork: false
hostNetwork: false
# Pod security context for Fluent Bit pods. Ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
podSecurityContext: {}
# Security context for Fluent Bit container. Ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
Expand Down Expand Up @@ -355,6 +355,10 @@ fluentd:
cpu: 100m
memory: 128Mi
schedulerName: ""
## Reference to one or more secrets to be used when pulling images
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
imagePullSecrets: []
# - name: "image-pull-secret"
logLevel: ""
extras: {}
# Configure the output plugin parameter in Fluentd.
Expand Down