Fix: Correct fluentd prase TimeFormat config key #780
Conversation
| TimeType *string `json:"timeType,omitempty"` | ||
| // Process value according to the specified format. This is available only when time_type is *string | ||
| // Process value according to the specified format. This is available only when time_type is string |
There was a problem hiding this comment.
should change like this?
| // Process value according to the specified format. This is available only when time_type is string | |
| // Process value according to the specified format. This is available only when time_format is string |
There was a problem hiding this comment.
It is correct how it is right now. The time_format only applies when time_type is set to the value string.
|
https://github.com/fluent/fluent-operator/blob/master/apis/fluentd/v1alpha1/tests/helper_test.go#L355 |
Yes, the CI error also needs to be fixed @Jakob3xD |
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Should be fixed now. I updated the key and removed the new line at the end of file which was added by my vim. |
|
@Jakob3xD Thank you |
What this PR does / why we need it:
It changes the TimeFormat config value from
time_typetotime_formatas it should be.Which issue(s) this PR fixes:
Fixes #778
Fixes #781
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: