fix(735): allow setting fluentd PodSecurityContext #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
reviewed
May 22, 2023
| @@ -86,6 +86,8 @@ type FluentdSpec struct { | |||
| VolumeClaimTemplates []corev1.PersistentVolumeClaim `json:"volumeClaimTemplates,omitempty"` | |||
| // Service represents configurations on the fluentd service. | |||
| Service FluentDService `json:"service,omitempty"` | |||
| // FSGroup represents the fsGroup that will be used in the fluentd PodSecurityContext. | |||
| FSGroup *int64 `json:"fsGroup,omitempty"` | |||
There was a problem hiding this comment.
@erhudy Thanks for the contribution.
I think we need to add SecurityContext field here just like fluentbit does:
https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/fluentbit_types.go#L77
There was a problem hiding this comment.
@benjaminhuo updated, sorry for the delay.
erhudy
force-pushed
the
set-sts-fsgroup
branch
2 times, most recently
from
b2d1f58 to
9829add
Compare
erhudy
changed the title
This allows setting the PodSecurityContext for the fluentd pods. If unset, defaults to a PSC with fsGroup=101 (matching the kubesphere fluentd images). Signed-off-by: Edmund Rhudy <[email protected]>
benjaminhuo
approved these changes
May 28, 2023
|
@erhudy Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fsGroup as a field that can be set in the CRD and sets it to the kubesphere fluentd image default of 101 if not explicitly configured.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #735
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: