add some fluentbit helm opts #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adiforluls <[email protected]>
|
Thanks for the PR. |
|
Just needed to test it, this is ready now @benjaminhuo |
wenchajun
approved these changes
May 22, 2023
benjaminhuo
reviewed
May 23, 2023
| @@ -18,6 +18,10 @@ spec: | |||
| resources: | |||
| {{- toYaml .Values.fluentbit.resources | nindent 4 }} | |||
| fluentBitConfigName: fluent-bit-config | |||
There was a problem hiding this comment.
The fluentBitConfigName and namespaceFluentBitCfgSelector should be mutually exclusive?
There was a problem hiding this comment.
Yeah, the former is for ClusterFluentBitConfig CR, and the latter is for namespaced FluentBitConfig CR.
This was a mistake made by whoever created/generated the FluentBit CR, they named the field corresponding to cluster level config as fluentBitConfigName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: