Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uri field for each telemetry type in opentelemetry plugin, remove old uri field #708

Merged
merged 4 commits into from
May 4, 2023

Conversation

JensLoe
Copy link
Contributor

@JensLoe JensLoe commented Apr 28, 2023

What this PR does / why we need it:

Adds a field for each telemetry type in the opentelemetry clusteroutput-plugin so it matches the fluent bit opentelemetry output, as described in the docs

Which issue(s) this PR fixes:

Fixes #707

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Copy link
Member

@wenchajun wenchajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should generate the appropriate CRD etc. files.

@wenchajun
Copy link
Member

make manifests
make generate

@JensLoe
Copy link
Contributor Author

JensLoe commented Apr 29, 2023

I have generated the files by running make manifests and make generate. Also generated the API-docs by running go run cmd/doc-gen/main.go. Let me know if there is anything else i should do (or undo).

@wenchajun wenchajun requested a review from benjaminhuo April 30, 2023 00:25
@benjaminhuo benjaminhuo merged commit c3e1dcb into fluent:master May 4, 2023
@benjaminhuo
Copy link
Member

@JensLoe Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the fluentbit opentelemetry clusteroutput-plugin to accept logs, metrics, and traces uri
3 participants