add loki outpt support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanjunlei <[email protected]>
benjaminhuo
requested changes
Dec 25, 2020
| // The loki output plugin, allows to ingest your records into a Loki service. | ||
| type Loki struct { | ||
| // Loki hostname or IP address. | ||
| Host string `json:"host,omitempty"` |
There was a problem hiding this comment.
Host shouldn't be allowed to be empty.
And other items having default values should be set to a default value if they're empty.
There was a problem hiding this comment.
If the item is empty, the fluent bit will use the default value, it is no need to set a default value in the config file.
Signed-off-by: wanjunlei <[email protected]>
benjaminhuo
approved these changes
Dec 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanjunlei [email protected]