[test]Add e2e testcases, integrates with CI #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhu733756 <[email protected]>
Signed-off-by: zhu733756 <[email protected]>
Signed-off-by: zhu733756 <[email protected]>
zhu733756
force-pushed
the
e2e
branch
4 times, most recently
from
7d6a984 to
4c70406
Compare
Signed-off-by: zhu733756 <[email protected]>
zhu733756
commented
Feb 21, 2022
| @@ -63,7 +63,7 @@ ENVTEST_ASSETS_DIR=$(shell pwd)/testbin | |||
| test: manifests generate fmt vet ## Run tests. | |||
| mkdir -p ${ENVTEST_ASSETS_DIR} | |||
| test -f ${ENVTEST_ASSETS_DIR}/setup-envtest.sh || curl -sSLo ${ENVTEST_ASSETS_DIR}/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.8.3/hack/setup-envtest.sh | |||
| source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out | |||
| source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./apis/... -coverprofile cover.out | |||
There was a problem hiding this comment.
Currently, the function tests are located in this path. Make it not include the e2e paths.
benjaminhuo
requested changes
Feb 21, 2022
| } | ||
|
|
||
| cfg.Spec.WatchedNamespaces = allNamespaces | ||
| // Don't patch the CR, or it would requeue. | ||
| cfg.Spec.WatchedNamespaces = watchedNamespaces | ||
| } |
There was a problem hiding this comment.
Do we have to put every namespace into WatchedNamespaces?
No easier way to represent all namespace instead of iterating every namespace?
There was a problem hiding this comment.
The former codes cache it, I wonder if the namespaces changed, would mix some namespaces.
There was a problem hiding this comment.
Let's discuss this later, I think there is no need to iterating every ns in case of all namespace
zhu733756
force-pushed
the
e2e
branch
2 times, most recently
from
5bd51da to
5610e17
Compare
Signed-off-by: zhu733756 <[email protected]>
Signed-off-by: zhu733756 <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zhu733756 [email protected]
/cc @benjaminhuo @wanjunlei @wenchajun