Allow fluent-operator to watch Kubernetes events #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r cluster role Signed-off-by: thomasgouveia <[email protected]>
benjaminhuo
reviewed
Jul 31, 2024
| @@ -31,6 +31,7 @@ rules: | |||
| - events | |||
| verbs: | |||
| - list | |||
| - watch | |||
There was a problem hiding this comment.
As I can remember the roles in charts and manifests are generated.
@wenchajun could you point out what else to modify?
cc @wanjunlei
Signed-off-by: thomasgouveia <[email protected]>
thomasgouveia
force-pushed
the
fix-1276-kube-events-watch-rbac
branch
from
38889d4 to
ff765bd
Compare
Signed-off-by: thomasgouveia <[email protected]>
|
@wenchajun done ! |
benjaminhuo
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds a missing RBAC verb to enable the proper functioning of the Kubernetes events input.
Which issue(s) this PR fixes:
Fixes #1276
Does this PR introduced a user-facing change?