Fixes fluentd/fluent-bit image build CI workflows #1259
Conversation
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
| @@ -18,76 +18,73 @@ permissions: | |||
| packages: write | |||
|
|
|||
| jobs: | |||
| build-amd64-prod-image-metadata: | |||
| determine-tags: | |||
There was a problem hiding this comment.
Instead of "determining" the tabs in each "metadata" step -- we just do it once at the top of the workflow and then reference the outputs (tags) in other steps. This ensures that the tags are propagated correctly when copying the images from GHCR to Dockerhub.
Signed-off-by: Josh Baird <[email protected]>
| @@ -43,25 +43,6 @@ | |||
| required: true | |||
|
|
|||
| jobs: | |||
| check-image-exists: | |||
There was a problem hiding this comment.
As implemented, this check doesn't really provide any value because it's just checking to see if latest exists, and not that the tag that needs to be copied actually exists. I decided to remove it entirely, since the next step which actually tries to copy the image will fail if the image does not exist.
joshuabaird
changed the title
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
|
@joshuabaird Great! Thanks! |
|
Ops, looks like there're some issues https://github.com/fluent/fluent-operator/actions/runs/10086655163 |
|
Hmm. I'll take a look this morning. |
What this PR does / why we need it:
#1246 implemented changes that allow us to release "patch" releases of our fluent-bit and fluentd images, but it had a few bugs which are addressed in this PR.
Primarily, the logic that promotes and copies images to Dockerhub was broken for various reasons. This PR centralizes the management of patch tags (eg,
3.1.0-0) and removes some unnecessary checks/complexity. This ensures that there is consistent versioning across all tags/patch releases.