Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsersfile default parsers.conf path #1225

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

cw-Guo
Copy link
Collaborator

@cw-Guo cw-Guo commented Jul 1, 2024

What this PR does / why we need it:

Fixed a bug, which would invalidate the default fluent-bit parsers conf

Which issue(s) this PR fixes:

Fixes #1219

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@benjaminhuo
Copy link
Member

benjaminhuo commented Jul 1, 2024

Thanks! @cw-Guo
cc @onecer @wanjunlei

@benjaminhuo benjaminhuo merged commit 1a1a1d3 into fluent:master Jul 1, 2024
2 checks passed
@elsnepal
Copy link

Thanks! @cw-Guo cc @onecer @wanjunlei

why those two parsers.conf & parsers_multiline.conf in different location?
This will fix default parser not being deployed but will this not break custom parser from loading?

@cw-Guo
Copy link
Collaborator Author

cw-Guo commented Jul 10, 2024

@elsnepal It won't affect the non-default parsers.

see here

COPY conf/fluent-bit.conf conf/fluent-bit.yaml conf/parsers.conf /fluent-bit/etc/

When we build the fluent-bit image, we copy conf/parsers.conf to /fluent-bit/etc/parsers.conf

in conf/parsers.conf, we include the non-default parsers. @INCLUDE /fluent-bit/config/parsers.conf

see https://github.com/fluent/fluent-operator/blob/master/conf/parsers.conf#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: default parsers are not deployed from fluent-operator
3 participants