Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templatize ServiceMonitor #1218

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

smallc2009
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1130

Does this PR introduced a user-facing change?

Add ServiceMonitor template to allow user to custom the values.

Additional documentation, usage docs, etc.:


Signed-off-by: Anson Liu <[email protected]>
@smallc2009 smallc2009 marked this pull request as ready for review June 23, 2024 23:08
Copy link
Contributor

@localleon localleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminhuo benjaminhuo merged commit c028c89 into fluent:master Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templatize ServiceMonitor
3 participants