-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support datadog plugin api key to allow for secret injection #1070
Conversation
f498740
to
33950aa
Compare
@nitintecg Thanks for this PR. make manifests
make generate
make fmt
make vet
make docs-update |
@benjaminhuo I'm getting below error while running
|
@wenchajun @wanjunlei This is an env issue? |
You can check the go and controller_gem version,https://github.com/fluent/fluent-operator/blob/master/Makefile#L149 |
@wenchajun Thanks, it was go version issue and after installing proper go version it resolved my issue. |
@nitintecg yeah, it's ok. Someone else forgets to generate docs for their PRs. |
@benjaminhuo i have added docs changes in this PR. Can you review ? |
@nitintecg thanks a lot for working on this! We're adopting fluent bit and definitely need this capability. |
@nitintecg would you help to resolve the conflicts? |
@benjaminhuo , i tried resolving conflicts and was running commands for generating docs but while running
Can you help me ? |
@nitintecg The error you had might have been fixed around the time you had it. Please see: #1120 |
Signed-off-by: nitintecg <[email protected]>
@nitintecg Thank you! |
What this PR does / why we need it:
Modified datadog_types.go file to support datadog plugin api key for allowing the value to take from secret.
Which issue(s) this PR fixes:
Fixes #1060
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: