Bump Golang version to 1.21 and replace slice utils with stdlib #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markusthoemmes Thanks for this PR. git commit -s --amend
git push -fAnd also please take a look at the CI errors, thanks! |
This bumps the Golang version used to build the module to 1.21. That enables us to make use of the new `slices` package, which implements generic functions over slices. Using those, we can remove the hand-crafted utils and replace them with direct usage of the standard library. Signed-off-by: Markus Thömmes <[email protected]>
markusthoemmes
force-pushed
the
golang1.21
branch
from
3570594 to
b5cb996
Compare
|
@benjaminhuo yeah I noticed that. Fixed the signing. |
Signed-off-by: Markus Thömmes <[email protected]>
markusthoemmes
force-pushed
the
golang1.21
branch
from
ad8e011 to
e645dc3
Compare
wenchajun
approved these changes
Jan 30, 2024
benjaminhuo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This bumps the Golang version used to build the module to 1.21. That enables us to make use of the new
slicespackage, which implements generic functions over slices. Using those, we can remove the hand-crafted utils and replace them with direct usage of the standard library.Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: