Fixed the .spec.loki.tls map rendering in FluentBit loki ClusterOutput #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Semichastnov <[email protected]>
benjaminhuo
reviewed
Dec 28, 2023
| @@ -108,7 +108,8 @@ spec: | |||
| {{ .removeKeys | toYaml | indent 6 }} | |||
| {{ end -}} | |||
|
|
|||
| {{ if .tls -}} | |||
| {{ if .tls }} | |||
There was a problem hiding this comment.
@wanjunlei @wenchajun should we keep the - here like {{ if .tls -}}?
There was a problem hiding this comment.
Just for the purpose of indentation and spacing, so I think it can be modified like this here.
wenchajun
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Semichastnov [email protected]
What this PR does / why we need it:
Fixed the .spec.loki.tls map rendering in FluentBit loki ClusterOutput
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: