Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver Output support for helm chart #1038

Closed
UgurcanAkkok opened this issue Jan 10, 2024 · 0 comments · Fixed by #1040
Closed

Stackdriver Output support for helm chart #1038

UgurcanAkkok opened this issue Jan 10, 2024 · 0 comments · Fixed by #1040
Labels
good first issue Good for newcomers

Comments

@UgurcanAkkok
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am deploying fluent operator to my GKE cluster, as i need a custom fluentbit deployment. I am using the helm chart with my values.yaml. The relavent fields are as follows:

# values.yaml
fluentbit:
  output:
    stackdriver:
      resource: k8s_container
      k8sClusterName: MYCLUSTER
      k8sClusterLocation: MYLOCATION

But the resulting output configuration is as follows:

# fluent-bit.conf
[Output]
    Name    null
    Match   *

Describe the solution you'd like

I am guessing we need a template file here for stackdriver: https://github.com/fluent/fluent-operator/tree/master/charts/fluent-operator/templates, just like the elasticsearch: https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentbit-output-elasticsearch.yaml

Since the CRDs for output support stackdriver, i think this would be enough ?

As an end user of this chart, i would like to be able to give the stackdriver values in the output field of the values.yaml (as given above).

Additional context

No response

@benjaminhuo benjaminhuo added the good first issue Good for newcomers label Jan 11, 2024
UgurcanAkkok added a commit to UgurcanAkkok/fluent-operator that referenced this issue Jan 14, 2024
UgurcanAkkok added a commit to UgurcanAkkok/fluent-operator that referenced this issue Jan 14, 2024
UgurcanAkkok added a commit to UgurcanAkkok/fluent-operator that referenced this issue Jan 14, 2024
benjaminhuo pushed a commit that referenced this issue Jan 15, 2024
* fix: add fluentbit stackdriver output #1038

Signed-off-by: Uğurcan Akkök <[email protected]>

* doc: update index.md for stackdriver output #1038

Signed-off-by: Uğurcan Akkök <[email protected]>

* fix comment for stackdriver in charts

Signed-off-by: Uğurcan Akkök <[email protected]>

---------

Signed-off-by: Uğurcan Akkök <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants