Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested transactions not supported error #376

Open
Dragomir-Ivanov opened this issue Jan 25, 2018 · 2 comments
Open

Nested transactions not supported error #376

Dragomir-Ivanov opened this issue Jan 25, 2018 · 2 comments
Labels

Comments

@Dragomir-Ivanov
Copy link

When playing with the-graph, trying to rapidly drag random nodes, quite often the drag operation doesn't happen, and in the JS console Nested transactions not supported appears.
What are these nested transactions in question? Thanks a lot.

@Dragomir-Ivanov Dragomir-Ivanov changed the title Nested transactions not supported error 'Nested transactions not supported' error Jan 25, 2018
@Dragomir-Ivanov Dragomir-Ivanov changed the title 'Nested transactions not supported' error Nested transactions not supported error Jan 25, 2018
@bergie
Copy link
Member

bergie commented Jan 26, 2018

the-graph uses the journal functionality from fbp-graph to bundle related operations together in a single transaction (for instance, removing a node and its associated edges together). Some background in noflo/noflo-ui#23

In this case it seems there are situations where user interaction (like dragging) didn't finish its transaction, and then a new dragging operation tries to start a new transaction which fails since there is one still active.

So yeah, sounds like a bug in drag-and-drop event handling

@bergie bergie added the bug label Jan 26, 2018
@Dragomir-Ivanov
Copy link
Author

@bergie Thanks for the quick answer. I guess we can make an exception about drag operation and allow its restarting without previous drag being ended.
I had another question here, can you take a look when time permits. #360

revilossor pushed a commit to revilossor/the-graph that referenced this issue Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants