Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "undo" #67

Closed
erkattak opened this issue Nov 21, 2014 · 6 comments
Closed

Support "undo" #67

erkattak opened this issue Nov 21, 2014 · 6 comments

Comments

@erkattak
Copy link

I'm not sure this is possible, but it'd be great to tell hubot to delete it's last message.

@Mumakil
Copy link
Contributor

Mumakil commented Nov 24, 2014

This might be possible, but I'd like to figure out first what's the motivation here and how would you expect this to work? Hubot might be talking in multiple flows and private conversations, so this would need to be on a per-flow basis. I'm thinking something like commenting the same thread and then hubot would delete the previous message.

Also, I'm not sure this is needs to be done in the flowdock adapter, since a script with a proper command sounds like a better fit.

@erkattak
Copy link
Author

Commenting in the same thread is how I imagined it working as well. The motivation here is that sometimes when using external services to search or display some content, it might return inappropriate results and we'd like to be able to censor hubot.

@Mumakil
Copy link
Contributor

Mumakil commented Nov 28, 2014

Thanks for the clarification! I feel this would better fit a userscript since it's an explicit command and does not fall exactly into the domain of a connection adapter (nor does the hubot adapter have a common interface for this). That said, a script would still need to take into account which connection adapter is in use.

I'm closing this ticket since I don't think we'll be implementing this in hubot-flowdock for now, but if you want help with writing a userscript I'm happy to help!

@brentc
Copy link
Contributor

brentc commented Nov 28, 2014

I actually implemented this as a user script for our needs a while back. Because it's flowdock specific, I haven't released it anywhere, but here it is:

https://gist.github.com/brentc/63ce932e6c0dd8ea3b7a

@erkattak
Copy link
Author

erkattak commented Dec 1, 2014

Thanks @brentc that's exactly what I was thinking. This is similar

https://github.com/cdoughty77/hubot-flowdock-delete-message

@erkattak erkattak closed this as completed Dec 1, 2014
@Mumakil
Copy link
Contributor

Mumakil commented Dec 2, 2014

Great! I'll add these to the readme so maybe they are found more easily if anyone else needs similar functionality!

Mumakil added a commit that referenced this issue Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants