Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

furi_hal_random: Wait for ready state and no errors before sampling #3933

Merged

Conversation

n1kolasM
Copy link
Contributor

@n1kolasM n1kolasM commented Oct 4, 2024

When random output is not ready, but error state flags are not set, sampling of random generator samples zero until next value is ready.

What's new

Verification

  • Generate 40 bytes with simple random generator app. There are no zeroes in output with new firmware

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

When random output is not ready, but error state flags are not set,
sampling of random generator samples zero until next value is ready.
@hedger hedger added Bug Core+Services HAL, furi & core system services labels Oct 4, 2024
@skotopes
Copy link
Member

skotopes commented Oct 6, 2024

@n1kolasM nice catch

@skotopes skotopes merged commit cfb9c99 into flipperdevices:dev Oct 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Core+Services HAL, furi & core system services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

furi_hal_random returns values when RNG output is not ready
3 participants