refactor!: improved interface of cancellable tile loading #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `CancellableTileLoadingSupport` mixin on `TileProvider` with cancellable support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably how I should've implemented it in the first place back in #1622 - it's a much better interface and wouldn't have been breaking. However, it's too late now, so I've opened this as draft.
dart-lang/http#978 has been re-opened. I'm hopeful it will get merged at some point. If it does, we will want to more strongly enforce the cancellable mechanisms, and maybe that will be a good time to switch to an implementation like this.