Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump vite to 6.0.0-beta.8 #50

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Nov 5, 2024

Warning

This PR is blocked by this issue: https://github.com/vitejs/vite/pull/18395/files#r1832458011
Fixed by: vitejs/vite#18611 (this will apply only in the next Vite beta 10 release though)

@@ -140,28 +140,6 @@ export function createCloudflareEnvironmentOptions(
createEnvironment(name, config) {
return new CloudflareDevEnvironment(name, config);
},
optimizeDeps: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite's moved this option to the top level: vitejs/vite#18465

@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta8 branch from f66c929 to c0ac005 Compare November 5, 2024 19:16
@@ -178,7 +156,29 @@ export function createCloudflareEnvironmentOptions(
external: [...cloudflareBuiltInModules],
},
},
webCompatible: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They've also removed webCompatible and kind of replaced it with keepProcessEnv (vitejs/vite#18395 (comment))

@jamesopstad
Copy link
Contributor

I think it's best to hold off upgrading until #49 is merged.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta8 branch from c0ac005 to cd6d5fa Compare November 7, 2024 10:18
Comment on lines -36 to -37
// We want to use `workerd` package exports if available (e.g. for postgres).
conditions: ['workerd'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petebacondarwin I needed to move this to the environment config since conditions is no longer inherited by environments (source change) I hope this is fine, was there a particular reason why you added the conditions here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the place I found that worked. But if it works in the environment config that is also cool.
Does that cover builds too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that cover builds too?

It is a top-level configuration so I would definitely say yes 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh.... but it seems like we have other build issues.... I'll bring them up in chat

@petebacondarwin petebacondarwin marked this pull request as draft November 7, 2024 14:50
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to fixing up Vite platform issue.

@petebacondarwin
Copy link
Contributor

Actually the CI jobs are not happy at all...

@dario-piotrowicz
Copy link
Contributor Author

Actually the CI jobs are not happy at all...

yes, things only pass with my local version of vite (unless I do apply a pnpm patch)

@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta8 branch from 6b077cc to debe5e0 Compare November 8, 2024 15:34
@dario-piotrowicz dario-piotrowicz force-pushed the dario/bump-vite-to-beta8 branch from 3463e5c to 9199a52 Compare November 8, 2024 16:08
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 8, 2024 16:13
Copy link
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dario-piotrowicz dario-piotrowicz merged commit 25f8cd6 into main Nov 11, 2024
3 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/bump-vite-to-beta8 branch November 11, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants