Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set more explicit error message when network config is missing in etcd #1606

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Set more explicit error message when network config is missing in etcd #1606

merged 1 commit into from
Jul 6, 2022

Conversation

thomasferrandiz
Copy link
Contributor

Description

The PR makes the error message more explicit when flannel config is not found in etcd.
It suggests to check that the config is stored using etcdv3 API since users might not have noticed that we changed the version we are using.

It also removes completely the custom error errKeyNotFound which is a duplicate of rpctypes.ErrGRPCKeyNotFound.

Todos

  • [ X ] Tests
  • [ X] Documentation
  • [ X] Release note

Release Note

None required

@thomasferrandiz thomasferrandiz requested a review from rbrtbnfgl July 6, 2022 09:34
@thomasferrandiz
Copy link
Contributor Author

#1584

@thomasferrandiz thomasferrandiz merged commit 0716f94 into flannel-io:master Jul 6, 2022
@thomasferrandiz thomasferrandiz deleted the warning-etcd-v3 branch July 6, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasferrandiz @rbrtbnfgl