Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public ip dualstack #1600

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Conversation

rbrtbnfgl
Copy link
Contributor

@rbrtbnfgl rbrtbnfgl commented Jun 27, 2022

Description

Fix #1596 when Public IPv6 is configured the right interface will be selected and no errors occur in case of dualstack.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

Copy link

@pranavadn pranavadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We patched and tested. Flannel came up fine and picked up the IPs we specified in command line args. Looks good to me.

@rbrtbnfgl rbrtbnfgl force-pushed the public-ip-dualstack branch from 9214f64 to f4f02db Compare July 4, 2022 07:36
@rbrtbnfgl rbrtbnfgl merged commit c166d38 into flannel-io:master Jul 4, 2022
@rbrtbnfgl rbrtbnfgl deleted the public-ip-dualstack branch July 4, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flannel Dual Stack Does not work when both public-ip and public-ipv6 are specified
3 participants