Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed subnet allocation in case of etcd manager with IPv6 #1582

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

rbrtbnfgl
Copy link
Contributor

Description

Fix the subnet allocation in case of etcd when using IPv6 #1580 #1581

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

Copy link

@pranavadn pranavadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does sn6.IP.Cmp(config.IPv6SubnetMax) < 0 comparison not exclude the last subnet? This was also an issue in the original code that raised with 1581. It should be like the v4 comparison sn.IP <= config.SubnetMax.

@rbrtbnfgl
Copy link
Contributor Author

yes you are right, I thought that it was the first not acceptable IP but it is the latest. I'll fix it.

@pranavadn
Copy link

Looks good to me. Please go ahead and merge.

@pranavadn
Copy link

@rbrtbnfgl @manuelbuil Could we please get 0.18.2 image with these fixes?

Copy link

@pranavadn pranavadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@rbrtbnfgl rbrtbnfgl merged commit 0a88b15 into flannel-io:master Jun 16, 2022
@rbrtbnfgl rbrtbnfgl deleted the etcd-subnetv6 branch June 16, 2022 10:08
manuelbuil pushed a commit to manuelbuil/flannel that referenced this pull request Jun 22, 2022
Fixed subnet allocation in case of etcd manager with IPv6
manuelbuil pushed a commit to manuelbuil/flannel that referenced this pull request Jun 22, 2022
Fixed subnet allocation in case of etcd manager with IPv6
manuelbuil pushed a commit to manuelbuil/flannel that referenced this pull request Jun 22, 2022
Fixed subnet allocation in case of etcd manager with IPv6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants