-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed subnet allocation in case of etcd manager with IPv6 #1582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does sn6.IP.Cmp(config.IPv6SubnetMax) < 0 comparison not exclude the last subnet? This was also an issue in the original code that raised with 1581. It should be like the v4 comparison sn.IP <= config.SubnetMax.
yes you are right, I thought that it was the first not acceptable IP but it is the latest. I'll fix it. |
Signed-off-by: rbrtbnfgl <[email protected]>
Looks good to me. Please go ahead and merge. |
@rbrtbnfgl @manuelbuil Could we please get 0.18.2 image with these fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Fixed subnet allocation in case of etcd manager with IPv6
Fixed subnet allocation in case of etcd manager with IPv6
Fixed subnet allocation in case of etcd manager with IPv6
Description
Fix the subnet allocation in case of etcd when using IPv6 #1580 #1581
Todos
Release Note