-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade etcd client to v3 #1562
Upgrade etcd client to v3 #1562
Conversation
dd66bc4
to
c92d2a0
Compare
@thomasferrandiz can you merge all the code commits into one commit e.g. squash the lint changes into the rest of the code. I also would like you to split out the go.mod, go.sum and ./vendor changes into a separate commit with commit message of |
4c342b5
to
3a4cdf4
Compare
|
@thomasferrandiz merged your netlink upgrade, can you rebase this and we'll get it merged |
eb7c62c
to
22ba166
Compare
@luthermonson the PR is rebased. |
@manuelbuil give this a quick review but im feeling like we're done here now that ci works |
If we replace etcdv2 with etcdv3, we should also change the name of the subnet/etcdv2 directory, right? |
@manuelbuil thought about this a bit too after we talked... maybe just rename to etcd? do we really need the version in the dir name? |
good point. I don't think we do. So we could change it to etcd |
I thought about changing the name but it would have made the diff hard to read so I decided not to rename the folder. |
@sjoerdsimons @zhangzhangzf I think you are users of etcd subnet. Anything against this PR? If not we will merge it |
@thomasferrandiz squash that last commit into the first and let's get this merged |
05ddc91
to
b40d827
Compare
Description
This PR upgrades the etcd client to v3 to solve a CVE issue in the v2 client.
The registry tests now use
go.etcd.io/etcd/tests/v3/integration
instead ofmock_etcd
.This is why there are many new dependencies.
Todos
Documentation/upgrade.md
?Release Note