Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix document and comment of configuration #1555

Merged
merged 2 commits into from
Apr 14, 2022
Merged

fix document and comment of configuration #1555

merged 2 commits into from
Apr 14, 2022

Conversation

arkuchy
Copy link
Contributor

@arkuchy arkuchy commented Mar 28, 2022 •
edited
Loading

Description

@arkuchy
Copy link
Contributor Author

arkuchy commented Mar 31, 2022

It appears that SubnetLen, SubnetMin, IPv6SubnetLen, IPv6SubnetMin are not used when using kube subnet manager. If this is true, it should be noted in the document, or is it already written somewhere?

@manuelbuil
Copy link
Collaborator

It appears that SubnetLen, SubnetMin, IPv6SubnetLen, IPv6SubnetMin are not used when using kube subnet manager. If this is true, it should be noted in the document, or is it already written somewhere?

You are right. When using kube subnet those parameters are controlled by kubernetes flags. In that case, kubernetes is the one distributing ips across nodes

@luthermonson luthermonson merged commit 3357ec2 into flannel-io:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@luthermonson luthermonson luthermonson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkuchy @manuelbuil @luthermonson