-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for --iface-regex match interface with multi IP addresses #1538
Conversation
@ttys3 have you tested this on a real environment and does it fix your issues? we're ready to merge as it looks good but want to confirm |
@luthermonson yes, I just tested it on a new created Linux node. It works. /etc/systemd/system/flanneld.service
The interface is
|
2b7e73c
to
3c146db
Compare
e34f693
to
3f66201
Compare
@luthermonson PTAL, the CI need approve again |
3f66201
to
d682ce6
Compare
Could you please rebase? There is a new test in CI (golangci-lint) |
d682ce6
to
c7ca58b
Compare
rebased, PTAL @manuelbuil @luthermonson |
@ttys3 could you resolve the conflict please? After that I'll merge the PR. Sorry for the delay! |
… multi link-local addrs
0c18375
to
7caa6ac
Compare
@manuelbuil rebased. PTAL |
Description
resolve #981
if interface has multi IPs, current match implementation will failed to get the right IP.
for example, interface
dummy0
has 4 IPs:we expect to use
192\.168\.200\.\d+
as--iface-regex
option to get192.168.200.128
matched.Todos
Release Note