stop healthz http server cleanly #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
reviewed
Jan 31, 2022
| wg.Add(2) | ||
| go func() { | ||
| // when Shutdown is called, ListenAndServe immediately return ErrServerClosed. | ||
| if err := server.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) { |
There was a problem hiding this comment.
why && !errors.Is(err, http.ErrServerClosed)?
There was a problem hiding this comment.
We will call server.Shutdown() to shutdown healthz http server when global context is done, and when server.Shutdown() is called, the first goroutine function server.ListenAndServe() immediately return http.ErrServerClosed, so it means we will get http.ErrServerClosed when healthz http server close normally, and close normally should not panic.
|
@manuelbuil if you dont have any issues with this we will merge. i think it's clean and gtg |
luthermonson
approved these changes
Feb 17, 2022
manuelbuil
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stop healthz http server cleanly
Todos
Release Note