Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy path to clipboard using native separators #3136

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

petrugrd
Copy link
Contributor

This pull request fixes issue #3135

@mmahmoudian
Copy link
Member

Thanks, looks good to me. I still rather another dev review it, but I add it to next release milestone.

@mmahmoudian mmahmoudian requested a review from veracioux April 5, 2023 08:33
@mmahmoudian mmahmoudian added this to the v13 milestone Apr 5, 2023
@panpuchkov
Copy link
Contributor

It looks good, make it run without issues (clang-format) and we can merge it.
Sorry for the late response.

src/utils/screenshotsaver.cpp Outdated Show resolved Hide resolved
@veracioux
Copy link
Contributor

@petrucianno Thanks for the change. Did you run clang-format again? The clang-format Github action is failing.

@veracioux veracioux merged commit 05226bc into flameshot-org:master Sep 16, 2023
19 of 22 checks passed
@petrugrd petrugrd deleted the issue-3135-fix branch September 16, 2023 12:06
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Dec 22, 2023
* Copy path to clipboard using native separators

Signed-off-by: Petru Gurduza <[email protected]>

* Copy path to clipboard using native separators

Signed-off-by: Petru Gurduza <[email protected]>

* Use native separators in save path

Signed-off-by: Petru Gurduza <[email protected]>

---------

Signed-off-by: Petru Gurduza <[email protected]>
(cherry picked from commit 05226bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants