Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Alt-PrtScn as alternate method for initiating screen capture #2168

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kmeekva
Copy link

@kmeekva kmeekva commented Dec 17, 2021

Simple fix to allow Alt-PrtScr as alternative way of initiating screen capture on windows 10.
This should provide workaround for using keyboard to capture screen in windows when other WINDOWs defaults Bind to the PrtScr Key.

@veracioux
Copy link
Contributor

Closes #2167.

@borgmanJeremy
Copy link
Contributor

Rather than adding specifically Alt-PRNTSCREEn I think it would be better to allow users to set the hotkey.

This can be done the same way it was done on MacOS in this PR: #2098

@kmeekva
Copy link
Author

kmeekva commented Dec 21, 2021

I don't think I understand how the example for MAC OS works.

I thought I could just define with initial values and it would allow users to set hotkey.

But my code fails when I try to open the configuration file with message saying "The configuration contains an error. Falling back to default configuration."

@borgmanJeremy
Copy link
Contributor

Okay no problem, I just got my windows partition set up so I can take a look. I think this is the last pr before we beta v11

@borgmanJeremy
Copy link
Contributor

Okay the reason it is crashing has nothing to do with your change, you just were the first to find it :) Here is a picture of the fix, I can merge it tomorrow or you can make the fix on your branch. I dont have my ssh keys properly set up in windows.

image

That said, the hotkey change doesnt seem to be working

@aprilkenopsia
Copy link

is changing the keybind still being worked on?

@dt192
Copy link

dt192 commented Mar 20, 2023

This would be great to have, seems to be the only obvious large issue with the windows version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants