Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized settings setSaveAsFileExtension, saveAfterCopyPath #2393

Closed
mcp292 opened this issue Feb 7, 2022 · 13 comments
Closed

Unrecognized settings setSaveAsFileExtension, saveAfterCopyPath #2393

mcp292 opened this issue Feb 7, 2022 · 13 comments
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.

Comments

@mcp292
Copy link

mcp292 commented Feb 7, 2022

Flameshot Version

Flameshot v11.0.0 (-)
Compiled with Qt 5.15.2

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Arch Linux

Description

I get an error when trying to issue flameshot gui from a keybinding. I see no documentation listed in the README about an update breaking this.

Steps to reproduce

$ flameshot config --check
flameshot: error: Unrecognized setting: 'setSaveAsFileExtension'

flameshot: error: Unrecognized setting: 'saveAfterCopyPath'

Screenshots or screen recordings

No response

System Information

Arch Linux
dwm

@mcp292 mcp292 added the Unconfirmed Bug The bug is not confirmed by anyone else. label Feb 7, 2022
@borgmanJeremy
Copy link
Contributor

The sematics for some of the config options changed in version 11. But it should allow you to autoresolve them. It will blow away those options and you can reconfigure them in the gui.

@mcp292
Copy link
Author

mcp292 commented Feb 7, 2022

It sounds like you're describing "resolve" as just deleting those lines. I want those lines for reference so I can update the syntax. I'd rather know the syntax and have access to updated documentation than have to config through the gui. Is this possible?

@borgmanJeremy
Copy link
Contributor

borgmanJeremy commented Feb 7, 2022

@mmahmoudian do we have an update annotated config file? I tend to just edit with the GUI to figure out the variable name. (or just check the source)

@mmahmoudian
Copy link
Member

mmahmoudian commented Feb 7, 2022

@borgmanJeremy because the ini format does not support comment lines, I have already gave up on the idea of having a well-annotated config sample.

@mcp292 the setSaveAsFileExtension should be a string of lowercase letters of the extension (e.g png), I guess you have the messed up config which was introduced by a bug in v0.10.x. As for saveAfterCopyPath though, I don't think it is a valid config argument. We have savePath (which accepts a path) and saveAfterCopy (which is boolean), but we don't have their mix!

@mcp292
Copy link
Author

mcp292 commented Feb 8, 2022

@mcp292 the setSaveAsFileExtension should be a string of lowercase letters of the extension (e.g png), I guess you have the messed up config which was introduced by a bug in v0.10.x.

Will check it out and report back.

As for saveAfterCopyPath though, I don't think it is a valid config argument. We have savePath (which accepts a path) and saveAfterCopy (which is boolean), but we don't have their mix!

Very odd, I definitely found that in the documentation somewhere and have been using it for years. Might of been in flameshot config --help.

@mcp292
Copy link
Author

mcp292 commented Feb 8, 2022

@mcp292 the setSaveAsFileExtension should be a string of lowercase letters of the extension (e.g png), I guess you have the messed up config which was introduced by a bug in v0.10.x.

Yes this is what is there:

setSaveAsFileExtension=By extension [default: *.png] (*.png)

I am changing it to:

setSaveAsFileExtension=png

despite the *.png hint, yes?

@mcp292
Copy link
Author

mcp292 commented Feb 8, 2022

Where are the config file variables documented? I would like to know what savePathFixed does for example.

@borgmanJeremy
Copy link
Contributor

You would need to reference the source code. It's possible to modify the file by hand but isn't really intended.

@mcp292
Copy link
Author

mcp292 commented Feb 8, 2022

Okay thank you for clarifying, so my takeaway is for this project only config with the gui.

@borgmanJeremy
Copy link
Contributor

There is also the flameshot config sub command, but it's not great right now.

@veracioux has plans to improve it.

@mcp292
Copy link
Author

mcp292 commented Feb 8, 2022

Okay thank you very much for the info!

For anyone following this thread the supported solution is to hit Resolve All which will remove those options, then issue flameshot config to re-set them through the GUI.

In my case saveAfterCopyPath has been removed and setSaveAsFileExtension was renamed to saveAsFileExtension.

The proper syntax is:

saveAsFileExtension=png

@mcp292 mcp292 closed this as completed Feb 8, 2022
@mmahmoudian
Copy link
Member

There is still something you can do. You can use flameshot config --check to get some information on what is wrong and what is expected

@mcp292
Copy link
Author

mcp292 commented Feb 9, 2022

Thanks for the tip!

dmarcoux pushed a commit to dmarcoux/dotfiles that referenced this issue Aug 15, 2022
This is needed following the update to NixOS 22.05, which includes a new
version of Flameshot.

flameshot-org/flameshot#2393 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed Bug The bug is not confirmed by anyone else.
Projects
None yet
Development

No branches or pull requests

3 participants