-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering artifacts on edge of rope netting sprite #1014
Comments
Seems like this can be fixed by disabling MSAA. |
Disable MSAA when in pixel art mode. It seems to add artifacts with texture sampling. Example: fishfolk/jumpy#1014
I think the shrink/shift thing is basically unavoidable with nearest-neighbor filtering unless we make sure we constrain zooms to a specific increment of physical pixels. There are some related thoughts here: katharostech/bevy_retrograde#51 |
Right that makes sense regarding zoom levels, probably not something we want to change. |
Re-enabling msaa as I think the shimmering seems worse. The artifact here does rarely show up without AA, so changing that doesn't seem like the fix anyway. |
There's a possibility this could be related to texture atlas bleeding like forbjok/bevy_simple_tilemap#4 (comment), but I'm not sure. It's a problem that's plagued me and even Bevy: bevyengine/bevy#1949 I did figure out how to fix it, but this might be a different issue. It kind of lines up, though, because the bleeding issue tended to depend a lot of drivers/random nuances. |
That definitely seems like a potential cause - glad you have done some digging on this in the past. Maybe we take a dive on this after we make rendering changes in bones, might be easier to troubleshoot and experiment with the shaders / render pipeline settings a bit less deep in engine. |
Disable MSAA when in pixel art mode. It seems to add artifacts with texture sampling. Example: fishfolk/jumpy#1014
Fixes #1014 (for now). It sounds like a proper fix entails significant work; but to fix the immediate issue we can move the rope tiles away from any others so that those adjacent to them are blank. ## Before <img width="256" alt="before-asset" src="https://github.com/user-attachments/assets/41e8ffb8-4034-492b-9f17-ce182656679b"> <img width="256" alt="before-game" src="https://github.com/user-attachments/assets/e30bf931-ca2a-46a7-86b8-c2e6971e4155"> ## After <img width="256" alt="after-asset" src="https://github.com/user-attachments/assets/86342a5c-cab9-4caf-948b-ce01f68393b0"> <img width="256" alt="after-game" src="https://github.com/user-attachments/assets/df8c7c46-8a4d-4828-8370-fad89c108bdb">
Description
I have been seeing some thin black lines to the left of the rope netting. Might be related to texture sampling settings, or maybe with atlas?
EDIT:
It seems bevy defaults to nearest sampling which seems right. It seems to flicker in and out as camera moves, wonder if we have mip maps and if that would help.
To Reproduce
No response
Expected Behavior
No response
Additional Context
No response
Log Messages
No response
The text was updated successfully, but these errors were encountered: