Ksagiyam/hex interior facet #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/hex_interior_facet
branch
3 times, most recently
from
1097c28 to
e0862cb
Compare
|
docs build fails as there are TSFC changes. Docs build fine locally. |
ksagiyam
force-pushed
the
ksagiyam/hex_interior_facet
branch
from
e0862cb to
93cc6be
Compare
dham
previously approved these changes
Sep 11, 2024
ksagiyam
force-pushed
the
ksagiyam/hex_interior_facet
branch
from
93cc6be to
1feca7f
Compare
|
|
dham
reviewed
Oct 30, 2024
dham
reviewed
Oct 30, 2024
connorjward
requested changes
Oct 30, 2024
ksagiyam
force-pushed
the
ksagiyam/hex_interior_facet
branch
3 times, most recently
from
2fd00d5 to
777803a
Compare
ksagiyam
force-pushed
the
ksagiyam/hex_interior_facet
branch
2 times, most recently
from
460f458 to
89b86b4
Compare
|
Reviewed in a Firedrake meeting. Docs built fine locally. |
connorjward
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable interior facet integration on hex by applying correct permutation to the quadrature points on each side (
+and-).Note:
Another way of handling interior facet integration on hex would be to choose reference cell - physical cell mapping on each side so that permutation would not be needed.
Depend on:
firedrakeproject/tsfc#317
FInAT/FInAT#138
firedrakeproject/fiat#83