Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_messaging): update the readme.md file #3963

Closed
wants to merge 4 commits into from
Closed

docs(firebase_messaging): update the readme.md file #3963

wants to merge 4 commits into from

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Oct 27, 2020

Description

The portion of the Application.java file is not working. After some research I have got the working code which I have updated it.

Related Issues

#3952

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Abhishek01039 Abhishek01039 changed the title [firebase_messaging] update the readme.md file doc(firebase_messagin) update the readme.md file Oct 27, 2020
@Abhishek01039 Abhishek01039 changed the title doc(firebase_messagin) update the readme.md file docs(firebase_messagin) update the readme.md file Oct 27, 2020
@Abhishek01039 Abhishek01039 changed the title docs(firebase_messagin) update the readme.md file docs(firebase_messaging) update the readme.md file Oct 27, 2020
@Abhishek01039 Abhishek01039 changed the title docs(firebase_messaging) update the readme.md file docs(firebase_messaging): update the readme.md file Oct 27, 2020
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Oct 28, 2020

Hello @Ehesp, @Salakar and @helenaford
is there any issue in code because I have changed only the java part of readme.md file?
Thanks

@Abhishek01039
Copy link
Contributor Author

Hello @Salakar
have you updated this portion along with your PR?
Thanks

@firebase firebase locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants