Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_auth_web): add support for confirmPasswordReset #2559

Merged
merged 3 commits into from
May 25, 2020
Merged

feat(firebase_auth_web): add support for confirmPasswordReset #2559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a78d5a
[firebase_auth_web] Add missing confirmPasswordReset function.
slightfoot May 15, 2020
3e9513e
Merge branch 'master' into fix_missing_confirm_pass
Salakar May 25, 2020
ff615e2
Merge branch 'master' into fix_missing_confirm_pass
Salakar May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_auth/firebase_auth_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.2+3

* Implement `confirmPasswordReset`.

## 0.1.2+2

* Make the pedantic dev_dependency explicit.
Expand Down
6 changes: 6 additions & 0 deletions packages/firebase_auth/firebase_auth_web/lib/firebase_auth_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,4 +357,10 @@ class FirebaseAuthWeb extends FirebaseAuthPlatform {
// See https://github.com/flutter/flutter/issues/46021
throw UnimplementedError('verifyPhoneNumber');
}

Future<void> confirmPasswordReset(
Comment on lines +360 to +361
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @override?

String app, String oobCode, String newPassword) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a trailing comma after newPassword may yield a more pleasing formatting (like this one).

final firebase.Auth auth = _getAuth(app);
await auth.confirmPasswordReset(oobCode, newPassword);
}
}
2 changes: 1 addition & 1 deletion packages/firebase_auth/firebase_auth_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: firebase_auth_web
description: The web implementation of firebase_auth
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth/firebase_auth_web
version: 0.1.2+2
version: 0.1.2+3

flutter:
plugin:
Expand Down