Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce 1.0.0 compatibility for multiple plugins #2497

Closed
wants to merge 1 commit into from

Conversation

amirh
Copy link
Contributor

@amirh amirh commented May 5, 2020

Description

Announce that multiple packages are compatible with 1.0.0 and encourage users to set their constraints accordingly.

This is similar to flutter/plugins#2597, flutter/plugins#2604, and flutter/plugins#2734

Packages declared 1.0.0 compatible by this PR:

  • cloud_firestore
  • cloud_firestore_web
  • firebase_crashlytics
  • firebase_dynamic_links
  • firebase_in_app_messaging
  • firebase_ml_vision
  • firebase_performance
  • firebase_remote_config

Copy link

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Salakar
Copy link
Member

Salakar commented May 25, 2020

Sorry if I'm missing any context here but I'm not sure if this is still viable with the upcoming changes via #2582 - there will be API changes still prior to v1.0.0 - we're working on Cloud Firestore at the moment and for that one at least it's certainly not yet a stable API.

The others plugins are still in the pipeline but I'd imagine they'd be in a similar boat too.

@Salakar Salakar added the blocked: do-not-merge PR blocked externally label May 25, 2020
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked - see comment. Thanks

@amirh
Copy link
Contributor Author

amirh commented May 25, 2020

Sorry if I'm missing any context here but I'm not sure if this is still viable with the upcoming changes via #2582 - there will be API changes still prior to v1.0.0 - we're working on Cloud Firestore at the moment and for that one at least it's certainly not yet a stable API.

The others plugins are still in the pipeline but I'd imagine they'd be in a similar boat too.

@csells should we cancel this?

@csells
Copy link
Contributor

csells commented May 25, 2020

Certainly we can discuss it more.

@amirh amirh closed this May 26, 2020
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants