[firebase_messaging] Handle background messages on iOS #2016

tobiasjunsten · 2020-02-18T14:59:15Z

Description

Enable backgound handling on iOS to work the same way as android.

Related Issues

Related pull request

This pull request was inspired by this one: Pull request 53

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

… ios-background-support

…n readme (and some restructuring in readme)

Finn0811 · 2020-02-22T16:43:05Z

Really looking forward to this, thanks for your work!

navidonline · 2020-02-26T12:25:07Z

Thanks for your great work, only worked in background .when app killed not work?

josh-burton · 2020-02-26T18:34:46Z

@shell32 what device are you testing on? If you force kill an app on iOS (common when testing things like this) then iOS will not deliver push notifications to that app until the app or device is restarted.

navidonline · 2020-02-27T09:57:34Z

@shell32 what device are you testing on? If you force kill an app on iOS (common when testing things like this) then iOS will not deliver push notifications to that app until the app or device is restarted.

iphone 6 , ios 12
ok thanks

tobiasjunsten · 2020-02-28T08:12:56Z

@shell32, just as @athornz says the app is not receiving any push notifications if the app has been force-quit. If the app has been suspended by the system (which happens quite fast) the app should be woken up and get some time to process a notification. When I've been testing I've also noticed that it can take a couple of minutes sometimes before the app is woken up if it has been suspended. You can read a bit more here: https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623013-application#discussion

gustavoergalves · 2020-03-03T20:15:09Z

Looking forward to this, thanks for your work!

p30arena · 2020-04-01T10:43:12Z

can this pr solve this issue?
#357

tobiasjunsten · 2020-04-01T19:31:29Z

@p30arena No, it only deals with handling push messages when app is in background or suspended state for iOS.

campioncino · 2020-04-03T04:20:28Z

Can I finally see this behaviour in iOS?

tobiasjunsten · 2020-04-03T12:17:15Z

@campioncino this pull request is not adding that behaviour. It's just about adding background handling for push messages. So when your app is in the background you'll be able to provide a dart function/isolate that should handle the message.

campioncino · 2020-04-04T21:05:19Z

@campioncino this pull request is not adding that behaviour. It's just about adding background handling for push messages. So when your app is in the background you'll be able to provide a dart function/isolate that should handle the message.

I'm sorry, I mean : can I finally do something like the image.

Using onBackgroundMessage: backgroundMessageHandler
can I do something when my app is running in background?

tobiasjunsten · 2020-04-14T05:35:55Z

@campioncino Ok :) I guess that should be possible. Anything should be possible in the backgroundMessageHandler. Like fetching data from backend or trigger local notifications.

fanatic75 · 2020-06-23T05:33:12Z

@isaiahtaylor, please don't post android config on a thread for iOS. There is no point here.

isaiahtaylorhh · 2020-06-23T16:24:55Z

I edited my comment to note that this is not necessarily relevant to this issue, it's just something that you might run into following this path.

tobiasjunsten · 2020-06-30T09:53:43Z

@tobiasjunsten , I have tried this pull, so when I add content_available to my payload, the app suddenly loses connection with the console and I cannot read logs anymore.
`{
"to" : "",
 "content_available":true,
"data" : {
 "click_action": "FLUTTER_NOTIFICATION_CLICK",
 "title":"news",
 "body":"body",
 "newsID":200,
 "image_url":"https://media.wired.com/photos/5b899992404e112d2df1e94e/master/pass/trash2-01.jpg",
}
}`

If I remove the content_available:true, it doesn't do anything in the background with this branch. but as soon as I add, it loses connection with the machine and I cannot read further logs to see If I have received the data message

@fanatic75 have you tried the console app on iOS? If you lose the connection with the app in the IDE-console you should still be able to see the logs from the app in the stand alone console app.

fanatic75 · 2020-06-30T10:52:40Z

@

@tobiasjunsten , I have tried this pull, so when I add content_available to my payload, the app suddenly loses connection with the console and I cannot read logs anymore.
`{
"to" : "",
 "content_available":true,
"data" : {
 "click_action": "FLUTTER_NOTIFICATION_CLICK",
 "title":"news",
 "body":"body",
 "newsID":200,
 "image_url":"https://media.wired.com/photos/5b899992404e112d2df1e94e/master/pass/trash2-01.jpg",
}
}`
If I remove the content_available:true, it doesn't do anything in the background with this branch. but as soon as I add, it loses connection with the machine and I cannot read further logs to see If I have received the data message
@fanatic75 have you tried the console app on iOS? If you lose the connection with the app in the IDE-console you should still be able to see the logs from the app in the stand alone console app.

I have moved from data message to notification message which solves the background problem on IOS as well. OnLaunch is working once the app has been killed and onResume is working when the app is in background. Not using background message callback anymore on both platforms.
Though there is definitely something weird as the connection should not get closed and the app is still running fine without crashing.

oskara · 2020-07-07T06:29:16Z

packages/firebase_messaging/README.md

+| **Notification on Android** | `onMessage`       | Notification is delivered to system tray. When the user clicks on it to open app `onResume` fires if `click_action: FLUTTER_NOTIFICATION_CLICK` is set (see below). | Notification is delivered to system tray. When the user clicks on it to open app `onLaunch` fires if `click_action: FLUTTER_NOTIFICATION_CLICK` is set (see below). |
+|     **Notification on iOS** | `onMessage`       | Notification is delivered to system tray. When the user clicks on it to open app `onResume` fires.                                                                  | Notification is delivered to system tray. When the user clicks on it to open app `onLaunch` fires.                                                                  |
+| **Data Message on Android** | `onMessage`       | `onMessage` while app stays in the background.                                                                                                                      | *not supported by plugin, message is lost*                                                                                                                          |
+|     **Data Message on iOS** | `onMessage`       | Message is stored by FCM and delivered to app via `onMessage` when the app is brought back to foreground.                                                           | Message is stored by FCM and delivered to app via `onMessage` when the app is brought back to foreground.                                                           |


Is this right? Aren't background messages delivered through onBackgroundMessage after this patch?

oskara · 2020-07-07T06:29:20Z

packages/firebase_messaging/README.md

+    import firebase_messaging
+   ```
+
+1. Then add the following code to `AppDelegate.swift`:


Maybe you should specify where in AppDelegate.swift? E.g. didFinishLaunchingWithOptions if that is the case.

SKKurz · 2020-07-10T08:39:22Z

is it also possible to use the background message handling on an iOS Simulator? Or is this one of the things that only work on a proper iOS device?

oskara · 2020-07-21T22:05:11Z

is it also possible to use the background message handling on an iOS Simulator? Or is this one of the things that only work on a proper iOS device?

As far as I know this will only work on real devices.

owenkealey · 2020-08-14T04:03:30Z

Only conflicts are changelog and pubspec? This is a critical merge for my app.

# Conflicts: # packages/firebase_messaging/CHANGELOG.md # packages/firebase_messaging/pubspec.yaml Updated version in CHANGELOG.md and pubspec.yaml

csarigumba · 2020-08-21T17:33:40Z

Is this schedule for merge? We need this in our app.

LasseRosenow · 2020-08-18T13:30:30Z

packages/firebase_messaging/README.md

+| **Notification on Android** | `onMessage`       | Notification is delivered to system tray. When the user clicks on it to open app `onResume` fires if `click_action: FLUTTER_NOTIFICATION_CLICK` is set (see below). | Notification is delivered to system tray. When the user clicks on it to open app `onLaunch` fires if `click_action: FLUTTER_NOTIFICATION_CLICK` is set (see below). |
+|     **Notification on iOS** | `onMessage`       | Notification is delivered to system tray. When the user clicks on it to open app `onResume` fires.                                                                  | Notification is delivered to system tray. When the user clicks on it to open app `onLaunch` fires.                                                                  |
+| **Data Message on Android** | `onMessage`       | `onMessage` while app stays in the background.                                                                                                                      | *not supported by plugin, message is lost*                                                                                                                          |
+|     **Data Message on iOS** | `onMessage`       | Message is delivered to `onBackgroundMessage`. This is the case both when app is running in background and the system has suspended the app.                        | Whan app is force-quit by the user the message is not handled.                                                                                                      |


"Whan app is force-quit by the user the message is not handled.

You got a typo there. It should be called "When" :)

Thanks. Fixed.

tobiasjunsten · 2020-09-01T06:00:57Z

Hi @FirebaseExtended/invertase! Any chance you could take a look at this pull request? It's a really wanted feature for us and (as it seems) a lot of other people.

tobiasjunsten · 2020-09-07T09:43:12Z

Hi @Salakar! I tried to tag the @FirebaseExtended/invertase team as suggested here: FlutterFire Roadmap but don't seem to work. Any chance any of you could take a look at this pull request?

kristijandraca · 2020-10-01T12:35:55Z

Any updates on this?

nt4f04uNd · 2020-10-22T17:39:48Z

@collinjackson @Ehesp @kroikie @Salakar guys please review this one, we all need it 🙏🥺

Ehesp · 2020-10-22T17:43:44Z

Hold on to your hats... New dev release coming soon.

# Conflicts: # packages/firebase_messaging/CHANGELOG.md # packages/firebase_messaging/pubspec.yaml

nt4f04uNd · 2020-10-29T14:17:26Z

@ozcannn14 why would you JSON.stringify your "notification"? If you are sending this with the JS SDK it has to be an object I guess

gahms · 2020-10-29T15:14:22Z

I have used this PR and it works. One thing that bit me was that when testing with a local clone of the fork, it seems that firebase_messaging gets initialized before firebase_core and that is not handled very well in the FLTFirebaseMessagingPlugin initWithChannel:registrar:] method that fails silently ([FIRMessaging messaging] is nil).

An entirely different issue is that because of flutter/flutter#14815, I cannot do any of the processing I had in mind in the background isolate and thus it is effectively useless to me to have background support on iOS.

tobiasjunsten added 8 commits December 29, 2019 12:09

added ios support

8e841b3

- renamed variable and removed commented log

4d0844a

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

3ca64a2

… ios-background-support

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

08dcf2e

… ios-background-support

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

44b68ba

… ios-background-support

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

a87c807

… ios-background-support

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

79e3fa8

… ios-background-support

[firebase_messaging] Added instructions for ios background handling i…

07fc453

…n readme (and some restructuring in readme)

tobiasjunsten requested review from collinjackson and kroikie as code owners February 18, 2020 14:59

googlebot added the cla: yes label Feb 18, 2020

tobiasjunsten changed the title ~~[firebase_messaging] Handle background messages in iOS~~ [firebase_messaging] Handle background messages on iOS Feb 19, 2020

tobiasjunsten added 2 commits February 27, 2020 13:38

[firebase_messaging] Fixed some formatting

1824a2a

[firebase_messaging] Formatted the objective-c code

0225706

tobiasjunsten added 3 commits March 27, 2020 08:42

Merge master into ios-background-support

24cbd6f

[firebase_messaging] Fixed readme after merge

34ad709

[firebase_messaging] updated versions

afcb41b

p30arena mentioned this pull request Apr 1, 2020

[firebase_messaging] Should support Rich notifications by default on iOS. #357

Closed

oskara reviewed Jul 7, 2020

View reviewed changes

tobiasjunsten added 2 commits August 18, 2020 10:26

Merge branch 'master' into ios-background-support

685f549

# Conflicts: # packages/firebase_messaging/CHANGELOG.md # packages/firebase_messaging/pubspec.yaml Updated version in CHANGELOG.md and pubspec.yaml

[firebase_messaging] Updated readme with suggestions from @oskara

9d495bf

LasseRosenow reviewed Aug 22, 2020

View reviewed changes

tobiasjunsten added 2 commits September 1, 2020 07:54

Merge branch 'master' into ios-background-support

43deb43

- fixed spelling mistake in readme

5b71c9a

tobiasjunsten requested review from Ehesp and Salakar as code owners September 1, 2020 05:55

campioncino mentioned this pull request Oct 20, 2020

No Notification receive in background for IOS #3819

Closed

Merge branch 'master' into ios-background-support

e31f2cd

# Conflicts: # packages/firebase_messaging/CHANGELOG.md # packages/firebase_messaging/pubspec.yaml

jfaltis mentioned this pull request Oct 28, 2020

backToForeground() does not work when app is closed on Android flutter-webrtc/callkeep#21

Open

Salakar mentioned this pull request Nov 3, 2020

feat(firebase_messaging): roadmap rework #4012

Merged

10 tasks

Salakar closed this in #4012 Nov 3, 2020

firebase locked and limited conversation to collaborators Dec 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[firebase_messaging] Handle background messages on iOS #2016

[firebase_messaging] Handle background messages on iOS #2016

tobiasjunsten commented Feb 18, 2020 •

edited

Loading

Finn0811 commented Feb 22, 2020

navidonline commented Feb 26, 2020

josh-burton commented Feb 26, 2020

navidonline commented Feb 27, 2020 •

edited

Loading

tobiasjunsten commented Feb 28, 2020

gustavoergalves commented Mar 3, 2020

p30arena commented Apr 1, 2020

tobiasjunsten commented Apr 1, 2020

campioncino commented Apr 3, 2020 •

edited

Loading

tobiasjunsten commented Apr 3, 2020

campioncino commented Apr 4, 2020

tobiasjunsten commented Apr 14, 2020

fanatic75 commented Jun 23, 2020

isaiahtaylorhh commented Jun 23, 2020 •

edited

Loading

tobiasjunsten commented Jun 30, 2020

fanatic75 commented Jun 30, 2020

oskara Jul 7, 2020

oskara Jul 7, 2020

SKKurz commented Jul 10, 2020

oskara commented Jul 21, 2020

owenkealey commented Aug 14, 2020

csarigumba commented Aug 21, 2020

LasseRosenow Aug 18, 2020 •

edited

Loading

tobiasjunsten Sep 1, 2020

tobiasjunsten commented Sep 1, 2020

tobiasjunsten commented Sep 7, 2020 •

edited

Loading

kristijandraca commented Oct 1, 2020

nt4f04uNd commented Oct 22, 2020

Ehesp commented Oct 22, 2020

nt4f04uNd commented Oct 29, 2020 •

edited

Loading

gahms commented Oct 29, 2020

[firebase_messaging] Handle background messages on iOS #2016

[firebase_messaging] Handle background messages on iOS #2016

Conversation

tobiasjunsten commented Feb 18, 2020 • edited Loading

Description

Related Issues

Related pull request

Checklist

Breaking Change

Finn0811 commented Feb 22, 2020

navidonline commented Feb 26, 2020

josh-burton commented Feb 26, 2020

navidonline commented Feb 27, 2020 • edited Loading

tobiasjunsten commented Feb 28, 2020

gustavoergalves commented Mar 3, 2020

p30arena commented Apr 1, 2020

tobiasjunsten commented Apr 1, 2020

campioncino commented Apr 3, 2020 • edited Loading

tobiasjunsten commented Apr 3, 2020

campioncino commented Apr 4, 2020

tobiasjunsten commented Apr 14, 2020

fanatic75 commented Jun 23, 2020

isaiahtaylorhh commented Jun 23, 2020 • edited Loading

tobiasjunsten commented Jun 30, 2020

fanatic75 commented Jun 30, 2020

oskara Jul 7, 2020

Choose a reason for hiding this comment

oskara Jul 7, 2020

Choose a reason for hiding this comment

SKKurz commented Jul 10, 2020

oskara commented Jul 21, 2020

owenkealey commented Aug 14, 2020

csarigumba commented Aug 21, 2020

LasseRosenow Aug 18, 2020 • edited Loading

Choose a reason for hiding this comment

tobiasjunsten Sep 1, 2020

Choose a reason for hiding this comment

tobiasjunsten commented Sep 1, 2020

tobiasjunsten commented Sep 7, 2020 • edited Loading

kristijandraca commented Oct 1, 2020

nt4f04uNd commented Oct 22, 2020

Ehesp commented Oct 22, 2020

nt4f04uNd commented Oct 29, 2020 • edited Loading

gahms commented Oct 29, 2020

tobiasjunsten commented Feb 18, 2020 •

edited

Loading

navidonline commented Feb 27, 2020 •

edited

Loading

campioncino commented Apr 3, 2020 •

edited

Loading

isaiahtaylorhh commented Jun 23, 2020 •

edited

Loading

LasseRosenow Aug 18, 2020 •

edited

Loading

tobiasjunsten commented Sep 7, 2020 •

edited

Loading

nt4f04uNd commented Oct 29, 2020 •

edited

Loading