-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting nested functions when serving functions locally #677
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should keep supplying the "firebase" option when deploying the functions, since it's still useful. Looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update package.json to beta.4 of GCF emulator? And only merge this branch once that's actually released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, please merge once GCF emulator beta.4 is released.
Description
Allow for nested functions to be locally emulated in response to customer issue #481 . Nested functions can now be accessed using dot notation. For example, given
exports.funcName = {
func1: functions.database.ref().onCreate(...),
func2: functions.https.onRequest(...)
}
func1 and func2 can be accessed using funcName.func1 and funcName.func2 respectively.
Depends on googlearchive/cloud-functions-emulator#191
Scenarios Tested
Tested against https nested functions two levels deep and database nested functions one level deep.
Sample Commands