README: add section about using Firebase from a framework #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested changes
Mar 24, 2020
|
This is awesome Maksym, thank you! |
paulb777
reviewed
Mar 25, 2020
There was a problem hiding this comment.
I might not be fully understanding the pictures.
For me, it would be most illustrative to show before and after linking for both cases. In the static after case, everything is in the app box. In the dynamic case there is a copy of the static library both in the app and the dynamic library that will be loaded later at runtime.
docs/firebase_in_libraries.md
Outdated
| use both the dynamic framework and one of its static dependencies directly in your app or another framework. In this case if you attempt to link | ||
| the same static framework/library to both the app and the dynamic framework you will end up with the static framework symbols added to both the app and the dynamic framework binaries. It means that when you app launches | ||
| it will have two copy of the static framework symbols. This leads to undefined behavior (especially when | ||
| different versions of the static framework are linking to the app and the dynamic framework). For example, a `dispatch_once` may or may not do the right initialization since there are now two entities to initialize. Here are couple more examples of issues related to this undefined behavior: #4315, #5152, etc. |
There was a problem hiding this comment.
Looks like GitHub links don't work from markdown. Please make into markdown links.
Also keep line lengths < 100 so the md file is readable in code editors
|
I'm going to merge this PR as is, but feel free to provide feedback to be addressed in the followup PRs. |
pranavrajgopal
pushed a commit
that referenced
this pull request
Apr 8, 2020
* [WIP] README: add section about using Firebase from a framework. * Typos, wording and examples * Move to a separate file * Add diagrams * Errors and issues examples. Cleanup. * Formatting * Issue links
ryanwilson
pushed a commit
that referenced
this pull request
Apr 24, 2020
* [WIP] README: add section about using Firebase from a framework. * Typos, wording and examples * Move to a separate file * Add diagrams * Errors and issues examples. Cleanup. * Formatting * Issue links
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A README section to address the confusing related to using Firebase from a framework/library. This should help developers with issues like firebase/quickstart-ios#936, #5152, #4315, etc.
#no-changelog