Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Move away from private typedef #14254

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[Config] Move away from private typedef #14254

merged 1 commit into from
Dec 13, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 13, 2024 •
edited
Loading

This is going into the rc-swift branch for the RC Swift port. The typedefs interfere with translation into Swift. The typedef is defined in a private header so should be OK to remove.

#no-changelog

@ncooke3 ncooke3 requested a review from morganchen12 December 13, 2024 18:02
@ncooke3 ncooke3 merged commit 1098342 into rc-swift Dec 13, 2024
31 of 32 checks passed
@ncooke3 ncooke3 deleted the nc/rc-swift-1 branch December 13, 2024 18:22
@ncooke3 ncooke3 mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @morganchen12 @google-oss-bot