Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sort document reference by long type id #14248

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Dec 12, 2024

Document ID supports strings and well as long integers in the format of "id" . When sorting documents by document ID, it should be sorted in the following order:

  1. Long (numeric order)
  2. String (lexicographic order)

#no-changelog

Firestore/core/src/model/base_path.h Outdated Show resolved Hide resolved
Firestore/core/src/model/base_path.h Outdated Show resolved Hide resolved
Firestore/core/src/model/base_path.h Outdated Show resolved Hide resolved
@milaGGL milaGGL requested a review from ehsannas December 16, 2024 20:33
@milaGGL milaGGL merged commit 0d569cf into main Dec 17, 2024
35 checks passed
@milaGGL milaGGL deleted the mila/fix-sdk-sort-document-reference-bug branch December 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants