[rc] Mark ConfigUpdateListenerRegistration Sendable #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple API Diff ReportCommit: a884b8a FirebaseRemoteConfigClasses[MODIFIED] FIRConfigUpdateListenerRegistration[MODIFIED] FIRConfigUpdateListenerRegistrationSwift:
+ class ConfigUpdateListenerRegistration : NSObject , @unchecked Sendable
- class ConfigUpdateListenerRegistration : NSObject
- func remove ()
Objective-C:
+ @interface FIRConfigUpdateListenerRegistration : NSObject
- @interface FIRConfigUpdateListenerRegistration : NSObject
- - ( void ) remove ; |
|
Presumably a bug in the API checker showing the removal of |
ncooke3
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
This may generally be safe, but the class retains a RCNRealtime instance which should be marked as Sendable. I'm looking at the requirements from https://developer.apple.com/documentation/swift/sendable#Sendable-Classes
I'll give the RCNRealtime implementation a scan to see if it looks thread-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14215