Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Run Imagen integration tests on cron schedule only #14231

Merged
merged 3 commits into from
Dec 7, 2024
Merged

[Vertex AI] Run Imagen integration tests on cron schedule only #14231

merged 3 commits into from
Dec 7, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Dec 7, 2024 •
edited
Loading

Updated the testGenerateImage_inlineData integration test to only run during nightly scheduled cron jobs or when the workflow is initiated manually. #14221

  • Added workflow_dispatch option to allow it to be started manually.
  • Updated the test to check the image size instead of using Gemini to verify the contents.
    • This should be more deterministic and will make it easier to split out the Imagen tests into a separate file.
  • For this PR, I tested the integration test manually by specifying the VTXIntegrationImagen environment variable in Xcode.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review December 7, 2024 20:56
@andrewheard andrewheard requested a review from paulb777 December 7, 2024 20:57
@andrewheard andrewheard mentioned this pull request Dec 7, 2024
Merged
@andrewheard andrewheard merged commit 8bc3978 into vertex-imagen Dec 7, 2024
50 checks passed
@andrewheard andrewheard deleted the ah/vertex-imagen-cron branch December 7, 2024 22:13
andrewheard added a commit that referenced this pull request Dec 9, 2024
@andrewheard
[Vertex AI] Run Imagen integration tests on cron schedule only (#14231)
36a76e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777