Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Make ImageGenerationResponse generic and add image types #14224

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[Vertex AI] Make ImageGenerationResponse generic and add image types #14224

merged 2 commits into from
Dec 6, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Dec 6, 2024 •
edited
Loading

Updated ImageGenerationResponse to be a generic type and added ImagenInlineDataImage (base64) and ImagenFileDataImage (GCS) for the two types of images that will be returned. Deleted DecodableImagenImage since the Codable implementations are now handled in these two new image types specifically. #14221

#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

@andrewheard andrewheard requested a review from paulb777 December 6, 2024 20:50
@andrewheard andrewheard marked this pull request as ready for review December 6, 2024 21:01
@andrewheard andrewheard merged commit 9d0a8d8 into vertex-imagen Dec 6, 2024
50 checks passed
@andrewheard andrewheard deleted the ah/vertex-imagen-response branch December 6, 2024 21:33
andrewheard added a commit that referenced this pull request Dec 9, 2024
@andrewheard
[Vertex AI] Make ImageGenerationResponse generic and add image types (
c2888bd 
#14224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777