-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Add default values for decoding nil properties in UserInfoImpl #14185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Would you update the release note to say this part of the fix will be in the 11.6.0 source distros and 11.7.0 binary distros
ncooke3
commented
Nov 28, 2024
paulb777
reviewed
Nov 28, 2024
ncooke3
commented
Nov 28, 2024
ncooke3
commented
Nov 28, 2024
ncooke3
commented
Nov 28, 2024
paulb777
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #14011 (comment)
If a
UserInfoImpl
instance fails to decode, the entire[String: UserInfoImpl]
collection (below snippet) will fail to decode, which will make theuser.providerData
propertynil
.firebase-ios-sdk/FirebaseAuth/Sources/Swift/User/User.swift
Lines 1736 to 1737 in 2176e99
The below snippet is the
GetAccountInfoResponseProviderUserInfo
response object for an account with email and phone providers enabled. Thephone
provider does not have afederatedID
and therefore its correspondingUserInfoImpl
instance does not have auid
. It's possible a more useful default could be given, but will have to further investigate this. cc: @Xiaoshouzi-ghFalling back to "" is slightly safer than the ObjC implementation, that would bridge to an implicit nil because of
UserInfo
's non-nulluid
interface (UserInfoImpl
conforms toUserInfo
).